Refine the unit test of convolution function. #3392
Conversation
|
More and more test files are added to paddle/function, for users, it looks very messy, should we consider to building a folder ? |
|
The refinement of the test of convolution function looks great to me. |
Put the test file and source file in one directory is a new convention. You can see in the |
| CHECK_EQ(strideW(), 1); | ||
|
|
||
| // TODO(hedaoyuan): There has some bug when batchSize > 1 and groups_ > 1. | ||
| CHECK_EQ(groups_, (size_t)1); |
There was a problem hiding this comment.
(size_t)1 ==> size_t(1) or static_cast<size_t>(1), according to Google C++ style https://google.github.io/styleguide/cppguide.html#Casting
There was a problem hiding this comment.
Thanks for pointing out. Done.
* fix bug when benchmark=True * split warmup and repeat
No description provided.